-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pagination to the Babies and Caregivers Tables #136
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for motherhoodbeyondbars failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great except the arrow should be an SVG instead! I can tell that you've put a lot of work into this, I appreciate the research you've done into pagination and the changes you've made to improve the codebase :D
onNextPage: any, | ||
onPrevPage: any | ||
) => [ | ||
{ symbol: "<", disabled: firstRecordOnPage <= pageSize, onClick: onPrevPage }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the svg instead of "<", you can download it from the Figma!
@@ -0,0 +1,21 @@ | |||
import { HTTP_STATUS_CODE } from "../consts"; | |||
|
|||
export abstract class DatabaseException extends Error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the organization for Exceptions, thanks for adding them!
What does this Pull Request change?
Adding pagination to the babies and caregivers tables.
Important Changes
Anything else?
Types need to be fixed, I kept the anys from before but it's not a good idea to let it go to prod with any typecasts lol