Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pagination to the Babies and Caregivers Tables #136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

uma-anand
Copy link

What does this Pull Request change?

Adding pagination to the babies and caregivers tables.

Important Changes

  • Creating a pagination component with arrows and texts
  • Adding pagination capabilities to babies and caregivers
  • Creating generic paginated table components and hooks
  • Cleaning a bit of the code around the database

Anything else?

Types need to be fixed, I kept the anys from before but it's not a good idea to let it go to prod with any typecasts lol

@uma-anand uma-anand self-assigned this Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for motherhoodbeyondbars failed. Why did it fail? →

Name Link
🔨 Latest commit 0ccf63e
🔍 Latest deploy log https://app.netlify.com/sites/motherhoodbeyondbars/deploys/66ec333a0ef744000805c9f0

Copy link
Contributor

@parkerra parkerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great except the arrow should be an SVG instead! I can tell that you've put a lot of work into this, I appreciate the research you've done into pagination and the changes you've made to improve the codebase :D

onNextPage: any,
onPrevPage: any
) => [
{ symbol: "<", disabled: firstRecordOnPage <= pageSize, onClick: onPrevPage },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the svg instead of "<", you can download it from the Figma!

@@ -0,0 +1,21 @@
import { HTTP_STATUS_CODE } from "../consts";

export abstract class DatabaseException extends Error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the organization for Exceptions, thanks for adding them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE/BE] Add Pagination to Caregiver, Children, and Item Requests Table
2 participants