Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pagination to the Babies and Caregivers Tables #136

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

uma-anand
Copy link
Contributor

What does this Pull Request change?

Adding pagination to the babies and caregivers tables.

Important Changes

  • Creating a pagination component with arrows and texts
  • Adding pagination capabilities to babies and caregivers
  • Creating generic paginated table components and hooks
  • Cleaning a bit of the code around the database

Anything else?

Types need to be fixed, I kept the anys from before but it's not a good idea to let it go to prod with any typecasts lol

@uma-anand uma-anand self-assigned this Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for motherhoodbeyondbars ready!

Name Link
🔨 Latest commit ecb7ebd
🔍 Latest deploy log https://app.netlify.com/sites/motherhoodbeyondbars/deploys/66f3291b05d12c00086e9a06
😎 Deploy Preview https://deploy-preview-136--motherhoodbeyondbars.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@parkerra parkerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great except the arrow should be an SVG instead! I can tell that you've put a lot of work into this, I appreciate the research you've done into pagination and the changes you've made to improve the codebase :D

web/components/molecules/Pagination/Pagination.tsx Outdated Show resolved Hide resolved
web/lib/exceptions/DatabaseExceptions.ts Show resolved Hide resolved
Copy link
Contributor

@parkerra parkerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the hard work and attention to detail, especially with types and code cleaning :D

@parkerra parkerra merged commit 74dd60e into main Sep 24, 2024
4 checks passed
@parkerra parkerra deleted the uma-125-pagination branch September 24, 2024 21:05
@uma-anand uma-anand linked an issue Sep 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants