Make multiblocks able to better modify their NEI preview #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyfts
added
refactor
OneEyeMaker
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs (but does not depend on) GTNewHorizons/BlockRenderer6343#26 to work
This aims to get rid of the janky workarounds that have been implemented to change the NEI preview in various multiblocks.
The interface is implemented in GT5U because I didn't feel like hard depping blockrenderer or using
@Optional.Interfacein every class.The janky workaround in God forge has been completely removed as it is no longer needed after GTNewHorizons/BlockRenderer6343#25
While trying to fix the piston in EIC I noticed that survival autobuild of those blocks were never implemented, this messed up the structure check when trying to build it and would cause way too many hatches to be placed.
That has been fixed and trying to autobuild an EIC will now result in a working one and preview will also correctly show the piston blocks.
Closes GTNewHorizons/GT-New-Horizons-Modpack#13795