Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ways to modify ingredients shown on NEI #3805

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

miozune
Copy link
Member

@miozune miozune commented Jan 13, 2025

This PR adds ways to modify ingredients shown on NEI per recipemap in order to remove workarounds:

  • Source and Target Chamber recipes use custom recipe class to have additional information and add particle item to NEI without adding it to the actual recipe. While the latter use case is somewhat intended, the former should be eventually migrated to metadata. Leaving the latter makes migration to RA2 style impossible.
  • QFT and PCB Factory recipes have been changed to not have non-consumable items in item inputs and instead have them in metadata. To make NEI visual recipes to still have NC items, two separated recipemaps were created. Having two maps that serve similar mechanism is confusing and prone to bugs.

New method introduced in this PR addresses those issues and hopefully provides more flexible design in future recipe logic.

Merge together with GTNewHorizons/NewHorizonsCoreMod#1163

@miozune miozune requested a review from a team January 13, 2025 15:05
@miozune miozune added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Jan 13, 2025
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor, this should make behaviors like this a lot easier to do now. I have just one small comment

@serenibyss serenibyss merged commit c5b7781 into master Jan 14, 2025
5 checks passed
@serenibyss serenibyss deleted the feature/nei-recipe-modify branch January 14, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants