Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UV Pump and Field Generator recipe correction in CoAL #3889

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

FrostyFire1
Copy link
Contributor

Field generators used molten neutronium instead of molten americium and pumps used too much Indalloy 140

@TheEpicGamer274 TheEpicGamer274 added the bug fix Fix a bug. Please link it in the PR. label Feb 4, 2025
Copy link
Member

@Dream-Master Dream-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain me why this need to be changed.

@FourIsTheNumber
Copy link
Contributor

Explain me why this need to be changed.

Bug. Was just a typo when recipe loader was migrated. These are the wrong materials/different numbers from what they are on stable.

@Dream-Master
Copy link
Member

Explain me why this need to be changed.

Bug. Was just a typo when recipe loader was migrated. These are the wrong materials/different numbers from what they are on stable.

so the old recipe has this ingredients? When this was wrongly changed? commit?

@FourIsTheNumber
Copy link
Contributor

Commit: #3837
The old loader was autogen, so it isn't easy to see. But here are some screenshots from stable
image
image
Note indalloy usage should be much lower for pump than field generator, and americium is just the wrong ingredient for uv field generator

@Dream-Master Dream-Master merged commit 33a332d into GTNewHorizons:master Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants