Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rock Breaker Fake Recipe #3890

Closed
wants to merge 7 commits into from
Closed

Conversation

Nockyx
Copy link
Contributor

@Nockyx Nockyx commented Feb 4, 2025

The new basalt recipe on boldarnator needs both soul sand and packed ice as NC items.
image

But the fake recipe only shows packed ice
image

This PR adds a new item slot to the rock breaker fake recipes, to show both items.
image

@Nockyx Nockyx added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Warning: 2 uncommitted changes
pull request create failed: GraphQL: Head sha can't be blank, Base sha can't be blank, Head repository can't be blank, No commits between GTNewHorizons:rock-breaker-recipe-map-fix and origin:GTNewHorizons-rock-breaker-recipe-map-fix-spotless-fixes, Head ref must be a branch, not all refs are readable (createPullRequest)

@EnderProyects
Copy link
Contributor

I think LazyFlesh did that like that because the soulsand is not an input, is a block you place bellow, so like the lava and water in the cobblestone recipe, they dont sow up

@Dream-Master Dream-Master requested a review from a team February 4, 2025 18:28
@LazyFleshWasTaken
Copy link
Contributor

LazyFleshWasTaken commented Feb 4, 2025

I think LazyFlesh did that like that because the soulsand is not an input, is a block you place bellow, so like the lava and water in the cobblestone recipe, they dont sow up

That, and there was only one slot. The ice in input slot as NC item came before the realisation that "wait its actually easier to make it placed" but I also didn't want 3 blocks taken up, since that's quite a bit of used space, especially since one is lava.

Plus, I updated the Rock brekaer's tooltip, the sb one.

@YannickMG
Copy link
Contributor

It's much better to take up blocks around the machine, we need to capitalize on machines that have unique mechanics.

Similarly this is a great opportunity to re-imagine this NEI handler to show that the blocks must be placed around the machine.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 5, 2025
@EnderProyects
Copy link
Contributor

@Dream-Master This "fix" is going to break other pr please dont merge

@LazyFleshWasTaken
Copy link
Contributor

LazyFleshWasTaken commented Feb 6, 2025

The new basalt recipe on boldarnator needs both soul sand and packed ice as NC items. image

But the fake recipe only shows packed ice image

This PR adds a new item slot to the rock breaker fake recipes, to show both items. image

I just thought about this a bit more, and frankly, I think this would only cause confusion. The tooltips of the MB and SB are already modified to say what they need to make basalt.

@Dream-Master
Copy link
Member

@Dream-Master This "fix" is going to break other pr please dont merge

You it means it need the other pr to fix some stuff? If so why not build against the first pr branch instead ?

@Nockyx
Copy link
Contributor Author

Nockyx commented Feb 6, 2025

As this seems to only cause confusion related to working of the singleblocks i'm closing this pr.

@Nockyx Nockyx closed this Feb 6, 2025
@Dream-Master Dream-Master deleted the rock-breaker-recipe-map-fix branch February 7, 2025 00:34
@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants