Easily sync config values between server & client #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
approved these changes
Jan 19, 2025
|
Leaving this comment here for any future crashes that come out of this: I like the idea overall, but I think that syncing MC restart fields is a bad idea. A lot of configs use this for mixins, and also gate access to mixins introduced fields/changes later. Without an annotation processor to warn at compile time this leaves a lot of room open for immediate client side crashes if someone marks such a config as Sync without realizing the problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to easily sync config values from server -> client by simple annotating the config field (or class) with
@Config.Sync.All values are restored to their original value once the player leaves the server.
Tested with this lovely config https://github.com/GTNewHorizons/GTNHLib/blob/7b65533a67926446c2e98f77c4503578dd049226/src/main/java/com/gtnewhorizon/gtnhlib/config/TestConfig.java and everything seems to sync correctly.