Add suffixes 's' for stacks and 'i' for ingots of fluid to MathExpressionParser. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have it be S for Stacks I could see |
|
Right now both 's' and 'S', and both 'i' and 'I' work. All suffixes right now are case-insensitive (though it is possible to make different cases do different things in the future, if desired). |
|
Guess that works too |
Caedis
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to existing 'k', 'm', etc. suffixes, one can now type "4s" for 256 (4 stacks of typical items), or "8i" for 1,152 (8 ingots' worth of fluids, 8*144).
This should work everywhere that uses the parser; i.e., ModularUI and AE2 terminals.