Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport BlockPos#getAllInBox #49

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Backport BlockPos#getAllInBox #49

merged 3 commits into from
Aug 13, 2024

Conversation

miozune
Copy link
Member

@miozune miozune commented Aug 13, 2024

No description provided.

@miozune miozune requested a review from a team August 13, 2024 11:02
@miozune miozune requested a review from a team as a code owner August 13, 2024 11:02
eigenraven
eigenraven requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@eigenraven eigenraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add JavaDoc comments explaining that the bounds are inclusive ([x1,x2] and not for example [x1,x2))

@Caedis
Copy link
Member

Caedis commented Aug 13, 2024

Might I suggest adding a test if this repo is setup for them?

@miozune
Copy link
Member Author

miozune commented Aug 13, 2024

Might I suggest adding a test if this repo is setup for them?

Can I be lazy? It's straightforward backport and can't go wrong

eigenraven
eigenraven approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@eigenraven eigenraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I wonder if we should also add a Stream factory to match the iterator version with the "new" api (Spliterators are also a bit more efficient than classic Iterators)

@miozune miozune merged commit 5157c9c into master Aug 13, 2024
1 check passed
@miozune miozune deleted the feature/blockpos-getallinbox branch August 13, 2024 12:52
@FalsePattern FalsePattern mentioned this pull request Aug 22, 2024
Closed
FalsePattern added a commit to FalsePattern/FalseTweaks that referenced this pull request Aug 22, 2024
@FalsePattern
Fixed a crash caused by GTNewHorizons/GTNHLib#49
026e672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eigenraven eigenraven eigenraven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miozune @Caedis @eigenraven