Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a toggle for hotbar sorting #49

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Add a toggle for hotbar sorting #49

merged 1 commit into from
Jan 17, 2025

Conversation

0hwx
Copy link
Collaborator

@0hwx 0hwx commented Jan 17, 2025

No description provided.

@0hwx 0hwx requested a review from Caedis January 17, 2025 09:03
@Caedis
Copy link
Member

Caedis commented Jan 17, 2025

@0hwx
Copy link
Collaborator Author

0hwx commented Jan 17, 2025

Could you have made the change here instead? https://github.com/GTNewHorizons/InventoryBogoSorter/blob/master/src/main/java/com/cleanroommc/bogosorter/common/sort/GuiSortingContext.java#L177

I can't make that change, since it's used to separate the hotbar from the rest of the inventory. If I followed your suggestion and added a check there, when it turns false, it would sort the entire inventory, including the hotbar.

@Caedis Caedis merged commit 428eba8 into master Jan 17, 2025
1 check passed
@Caedis Caedis deleted the Hotbar-sort branch January 17, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants