Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast #52

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fix cast #52

merged 2 commits into from
Jan 17, 2025

Conversation

0hwx
Copy link
Collaborator

@0hwx 0hwx commented Jan 17, 2025

I was trying to add this mod back to MUI2 when I encountered an error: 'Cannot be cast to class com.cleanroommc.modularui.utils.item.IItemHandler.'

@0hwx 0hwx requested a review from Caedis January 17, 2025 17:15
@Caedis
Copy link
Member

Caedis commented Jan 17, 2025

What do you mean back to MUI2?

@0hwx
Copy link
Collaborator Author

0hwx commented Jan 17, 2025

there was a sort button in tile test block so I tried to readd it

@Caedis
Copy link
Member

Caedis commented Jan 17, 2025

I still dont understand the reason for this pr

@0hwx
Copy link
Collaborator Author

0hwx commented Jan 17, 2025

AE2 in version 1.12 uses IItemHandler, while ours uses IInventory. MUI2, on the other hand, uses IItemHandler, so this modification is necessary to prevent containers with MUI2 slots that implements ISortableContainer from crashing.

@0hwx 0hwx merged commit e8018dc into master Jan 17, 2025
1 check passed
@0hwx 0hwx deleted the cast branch January 17, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants