-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplex tree ctors with data #1151
base: master
Are you sure you want to change the base?
Simplex tree ctors with data #1151
Conversation
…rming constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it wanted that the non assigned data seems to take a random value ? For unit test "simplex_data", the output is:
(2 1 0 ) filtration=0 - data='4'
(1 0 ) filtration=0 - data='5'
(2 0 ) filtration=0 - data='43808336'
(0 ) filtration=0 - data='2'
(2 1 ) filtration=0 - data='43808304'
(1 ) filtration=0 - data='43808304'
(2 ) filtration=0 - data='43808304'
Data is of type int
and only 4 and 5 were assigned.
Co-authored-by: hschreiber <[email protected]>
Co-authored-by: hschreiber <[email protected]>
Co-authored-by: hschreiber <[email protected]>
It is the behaviour we want. We do not say it, but data are not initialized with a default value, that would take time. It is up to the user to deal with it. |
rec_copy
can copy or notsimplex_data
.Some documentation and tests to explain when data are copied or not.
Fix #1127