OpenImageDenoise + ISPC added #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Agreed. Unless we need it at runtime, it should be something we add to the build container. I see its BSD licensed, so that shouldn't be a problem to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just leaving this here if we want to get this up and running for Cycles - I had ISPC included in the bin/ manifest for some MoonRay experiments as that renderer uses it like a shader compiler, but I kept it out of this PR as it isn't needed to be packaged with Gaffer, only to build OpenImageDenoise.
Realistically it probably would make sense to leave ISPC as a prerequisite for the host's building environment instead of making it a package, open to suggestions...