-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aarch64
build fixes
#258
base: main
Are you sure you want to change the base?
aarch64
build fixes
#258
Conversation
Thanks Tom! I ran a build of this in a local GCC 11 container today with no apparent issue, so we could likely sneak this into the next dependencies release. I'm curious to hear more about your Alma |
Fixes compilation issues on aarch64.
Fixes aarch64 compilation issues
Allows build setting to be modified in an arch specific way. This can be useful on aarch64 where the required versions of dependencies may not build correctly without additional settings, or even be supported at all. (Discovered building on aarch64 on Alma 9, where OpenPGL only supports aarch64 in 0.6.0, which includes breaking changes that are not compatible with Cycles.
aarch64 is only supported in OpenPGL 0.6.0, Cycles 4.0.2 (latest at the time) uses the 0.5.0 API, so needs updating before it is compatible with the newer PGL library. In the interrim, disable Path Guiding/OpenPGL for Cycles on aarch64.
This OSL version doesn't doesnt support batched ops on aarch64 yet - incorrect -march mapping.
16e9a01
to
3288d6f
Compare
Thanks @murraystevenson - realised I forgot to update In general its not been too bad - have been using it under UTM (vs a boot partition), the kernel is still pretty old, so had to use the community kernel update to get |
Just discovered this needs a Gaffer change too - to disable OpenPGL linking in the GafferCycles build once this is no longer in the dependencies. |
Fixes required to get dependencies building under Alma on
aarch64
(M2).There is one remaining issue with (I think)
char
being unsigned onaarch64
, that causes a warnings-as-errors fail here:https://github.com/ImageEngine/cortex/blob/866905609dbf0023dce5a8a3bdcfed3126906576/src/IECoreScene/Font.cpp#L525
I've patched this by removing the check in my local build, but wasn't sure what the preferred upstream solution would be. The true scope of
-fsigned-char
is unknown to me.