-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Cycles 4.2.0 with OIDN support #266
Conversation
Download the same file from a mirror URL as we've been seeing intermittent download failures from ftp.gnome.org
Python builds on macOS attempt to install Python Launcher.app and IDLE.app to /Applications. The github provided macos-14 image already includes an install of Python 3.10, which causes our Python 3.10 build to fail as it cannot overwrite `/Applications/Python 3.10/Python Launcher.app` and `/Applications/Python 3.10/IDLE.app`. There appears to be no obvious way to configure our build to not install to /Applications, so we instead remove these conflicting paths for now...
The github macos-14 runner image provides it, which then causes our LibRaw builds to treat it as a dependency. We have no need for little-cms2 so we make sure to remove it.
Nice one Murray! For OpenImageDenoise I found that I couldn't load in Cycles if Arnold is also loaded in, and it was down to Arnold's version preventing Cycles to load. A way around this was to rename the library: Perhaps a prefix eg. "GafferOpenImageDenoise" is the way to go. I was able to get cycles to find this by patching their |
I did a build recently and saw that oslc needed |
Closing this as the Cycles 4.2.0 update has been handled as part of #267 and we'll investigate the OIDN issues separately at a later date... |
This updates Cycles to 4.2.0 with the addition of OpenImageDenoise 2.3.0. OIDN is built with OIIO support and the oidnDenoise binary is included in the manifest as it may be useful for anyone wishing to do post-process deniosing via a SystemCommand node. Zstd is also a new addition as it is now required by Cycles to compress and decompress GPU kernel .ptx and .cubin files.
The last few commits are attempts to address a couple of issues that have been preventing CI from running reliably.
@boberfly it'd be great to know if this works for you. There's one todo which will need to be addressed via a build container update, but that's just moving the creation of an environment variable to the right place...