-
Notifications
You must be signed in to change notification settings - Fork 206
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
USDShader : Fix loading of terminals with USD 24.08
At some point - and for reasons unknown - terminals started confidently declaring themselves as a cleanly mapped Token type in `SdrShaderProperty.GetTypeAsSdfType()`. This caused us to load them as StringPlugs, which certainly doesn't match the intent behind terminals. We now check the `SdrShaderProperty.GetType()` explicitly to detect terminals and vstructs so we can continue to load them as bare Plugs. This seems cleaner than the original approach, and lets us simplify `loadParameter()` such that it just needs to accept an `SdfValueTypeName` rather than the more convoluted `NdrSdfTypeIndicator` that has no relevance when loading from schemas rather than the shader registry.
- Loading branch information
1 parent
ac96930
commit 1c98ce4
Showing
1 changed file
with
65 additions
and
59 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters