Skip to content

Commit

Permalink
SpotLightHandle : Highlight only in highlight state
Browse files Browse the repository at this point in the history
I'm not sure why we were highlighting also if the drag was active, all of my testing indicates the highlight state is sufficient to keep the highlight active while dragging.

This hasn't caused problems for the `SpotLightHandle`, but it caused multiple `QuadLightHandle` to be highlighted incorrectly, so I'm matching the behavior here for consistency.
  • Loading branch information
ericmehl committed Aug 14, 2023
1 parent e487a81 commit 4cd579f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/GafferSceneUI/LightTool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1194,7 +1194,7 @@ class SpotLightHandle : public LightToolHandle

IECoreGL::GroupPtr group = new IECoreGL::Group;

const bool highlighted = state == Style::State::HighlightedState || m_drag;
const bool highlighted = state == Style::State::HighlightedState;

// Line along cone. Use a cylinder because GL_LINE with width > 1
// are not reliably selected.
Expand Down

0 comments on commit 4cd579f

Please sign in to comment.