Plug : Inline direction() and node()

This produces the following reductions in runtime : - ValuePlugTest.testCacheOverhead : 5% - ValuePlugTest.testContentionForOneItem : 1%
GafferHQ · Jul 11, 2023 · 4e7f400 · 4e7f400
1 parent c0e27a0
commit 4e7f400
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 16 deletions.
diff --git a/include/Gaffer/Plug.inl b/include/Gaffer/Plug.inl
@@ -37,9 +37,26 @@
 
 #pragma once
 
+#include "Gaffer/Node.h"
+
 namespace Gaffer
 {
 
+inline Node *Plug::node()
+{
+	return ancestor<Node>();
+}
+
+inline const Node *Plug::node() const
+{
+	return ancestor<Node>();
+}
+
+inline Plug::Direction Plug::direction() const
+{
+	return m_direction;
+}
+
 template<typename T>
 T *Plug::getInput()
 {
@@ -52,7 +69,6 @@ const T *Plug::getInput() const
 	return IECore::runTimeCast<const T>( m_input );
 }
 
-
 template<typename T>
 T *Plug::source()
 {

diff --git a/src/Gaffer/Plug.cpp b/src/Gaffer/Plug.cpp
@@ -136,21 +136,6 @@ bool Plug::acceptsParent( const GraphComponent *potentialParent ) const
 	return potentialParent->isInstanceOf( (IECore::TypeId)NodeTypeId ) || potentialParent->isInstanceOf( Plug::staticTypeId() );
 }
 
-Node *Plug::node()
-{
-	return ancestor<Node>();
-}
-
-const Node *Plug::node() const
-{
-	return ancestor<Node>();
-}
-
-Plug::Direction Plug::direction() const
-{
-	return m_direction;
-}
-
 unsigned Plug::getFlags() const
 {
 	return m_flags;