Merge pull request #5993 from johnhaddon/shaderRevertToDefaultsFix

ShaderUI : Mark `type` plug as read-only
GafferHQ · Aug 6, 2024 · 6f94c7b · 6f94c7b
2 parents a293f3c + a48851f
commit 6f94c7b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Changes.md b/Changes.md
@@ -15,6 +15,7 @@ Fixes
 - Arnold : Fixed bug preventing UI metadata for Imagers from being loaded for Arnold 7.3.
 - WidgetAlgo : Fixed issue preventing `grab()` from capturing popup menus on Windows.
 - ShowURL : Fixed opening of "file://" URLs on Windows (#5861).
+- Shader : Fixed "Revert to Defaults" menu item in NodeEditor (#1862).
 
 API
 ---

diff --git a/python/GafferSceneUI/ShaderUI.py b/python/GafferSceneUI/ShaderUI.py
@@ -90,7 +90,7 @@ def __parameterUserDefault( plug ) :
 			"description",
 			"""
 			The name of the shader being represented. This should
-			be considered read-only. Use the Shader.loadShader()
+			be considered read-only. Use the `Shader.loadShader()`
 			method to load a shader.
 			""",
 
@@ -107,10 +107,11 @@ def __parameterUserDefault( plug ) :
 			"description",
 			"""
 			The type of the shader being represented. This should
-			be considered read-only. Use the Shader.loadShader()
+			be considered read-only. Use the `Shader.loadShader()`
 			method to load a shader.
 			""",
 
+			"readOnly", True,
 			"layout:section", "",
 			"nodule:type", "",
 			"plugValueWidget:type", "",