Skip to content

Commit

Permalink
Merge pull request #5698 from johnhaddon/delightEnvFix
Browse files Browse the repository at this point in the history
IECoreDelight : Fix KeyError when `DELIGHT` not defined
  • Loading branch information
ericmehl authored Feb 27, 2024
2 parents 0199292 + 23879c9 commit 708833c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
7 changes: 7 additions & 0 deletions Changes.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
1.4.x.x (relative to 1.4.0.0b1)
=======

Fixes
-----

- 3Delight : Fixed startup errors on Windows when the `DELIGHT` environment variable wasn't defined [^1].

Breaking Changes
----------------

Expand All @@ -9,6 +14,8 @@ Breaking Changes
- Removed all texture cache options. These had never been exposed in the UI because this never became an offical Cycles feature.
- Removed `cryptomatteAccurate`. This feature is no longer present in Cycles.

[^1] : To be omitted from final release notes for 1.4.0.0.

1.4.0.0b1 (relative to 1.3.x.x)
=========

Expand Down
4 changes: 2 additions & 2 deletions python/IECoreDelight/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
import os
import pathlib

if hasattr( os, "add_dll_directory" ) :
if hasattr( os, "add_dll_directory" ) and "DELIGHT" in os.environ :
os.add_dll_directory( ( pathlib.Path( os.environ["DELIGHT"] ) / "bin" ).resolve() )
del os, pathlib # Don't pollute the namespace

Expand All @@ -56,4 +56,4 @@
try :
ctypes.CDLL( "IECoreDelight.dll" )
except :
raise ImportError
raise ImportError

0 comments on commit 708833c

Please sign in to comment.