VisualiserTool : Remove metadataChanged

We're not reading the metadata anywhere in the tool, so dirtying the tool in response to `metadataChanged` events won't have any effect.
GafferHQ · Dec 10, 2024 · bfa6c2b · bfa6c2b
1 parent 1c06490
commit bfa6c2b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 30 deletions.
diff --git a/include/GafferSceneUI/Private/VisualiserTool.h b/include/GafferSceneUI/Private/VisualiserTool.h
@@ -128,7 +128,6 @@ class GAFFERSCENEUI_API VisualiserTool : public SelectionTool
 		bool dragEnd( const GafferUI::DragDropEvent &event );
 		void plugDirtied( const Gaffer::Plug *plug );
 		void plugSet( const Gaffer::Plug *plug );
-		void metadataChanged( const IECore::InternedString &key );
 		void updateSelection() const;
 		void preRender();
 		void updateCursorPos( const GafferUI::ButtonEvent &event );

diff --git a/src/GafferSceneUI/VisualiserTool.cpp b/src/GafferSceneUI/VisualiserTool.cpp
@@ -44,9 +44,6 @@
 #include "GafferUI/Style.h"
 #include "GafferUI/ViewportGadget.h"
 
-#include "Gaffer/Metadata.h"
-#include "Gaffer/MetadataAlgo.h"
-
 #include "IECoreScene/MeshAlgo.h"
 #include "IECoreScene/MeshPrimitive.h"
 #include "IECoreScene/MeshPrimitiveEvaluator.h"
@@ -764,13 +761,6 @@ VisualiserTool::VisualiserTool( SceneView *view, const std::string &name ) : Sel
 		boost::bind( &VisualiserTool::selectedPathsChanged, this )
 	);
 
-
-	Metadata::plugValueChangedSignal().connect(
-		boost::bind( &VisualiserTool::metadataChanged, this, boost::placeholders::_3 )
-	);
-	Metadata::nodeValueChangedSignal().connect(
-		boost::bind( &VisualiserTool::metadataChanged, this, boost::placeholders::_2 )
-	);
 }
 
 VisualiserTool::~VisualiserTool()
@@ -1099,25 +1089,6 @@ void VisualiserTool::plugSet( const Plug *plug )
 	}
 }
 
-void VisualiserTool::metadataChanged( const InternedString &key )
-{
-	if( !MetadataAlgo::readOnlyAffectedByChange( key ) )
-	{
-		return;
-	}
-
-	if( !m_selectionDirty )
-	{
-		m_selectionDirty = true;
-	}
-
-	if( !m_gadgetDirty )
-	{
-		m_gadgetDirty = true;
-		view()->viewportGadget()->renderRequestSignal()( view()->viewportGadget() );
-	}
-}
-
 void VisualiserTool::updateSelection() const
 {
 	if( !m_selectionDirty )