Viewport hide objects #5381
Merged
Viewport hide objects #5381
+93
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
requested changes
Jul 6, 2023
|
Great! I fixed up the comments and squashed them down to ed1b6a5. Should be good to go I think. |
johnhaddon
requested changes
Jul 7, 2023
The tweak nodes should have their `enabled` plugs driven by the scene processor `enabled` plug. Previously we were only setting their value at creation time, and to a `Plug` object which will always evaluate to `True`.
|
A couple more tweaks taken care of and ready for a new look and hopefully merging! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new shortcut to the 3d viewer, Ctrl + H, to turn off visibility of the selected objects.
It also fixes a bug that left the enabled plug of some of the edit scope processors disconnected from their parent node. These should be connected to ensure disabled state is propagated.