Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightFilterVisualiser : Fix Arnold light blockers #5433

Merged
merged 1 commit into from
Aug 29, 2023
Merged

LightFilterVisualiser : Fix Arnold light blockers #5433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/GafferArnoldUI/BarndoorVisualiser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,11 @@ BarndoorVisualiser::~BarndoorVisualiser()

Visualisations BarndoorVisualiser::visualise( const IECore::InternedString &attributeName, const IECoreScene::ShaderNetwork *shaderNetwork, const IECoreScene::ShaderNetwork *lightShaderNetwork, const IECore::CompoundObject *attributes, IECoreGL::ConstStatePtr &state ) const
{
if( !lightShaderNetwork )
{
return {};
}

IECoreGL::GroupPtr result = new IECoreGL::Group();

const IECore::CompoundData *filterShaderParameters = shaderNetwork->outputShader()->parametersData();
Expand Down
5 changes: 5 additions & 0 deletions src/GafferArnoldUI/GoboVisualiser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,11 @@ GoboVisualiser::~GoboVisualiser()

Visualisations GoboVisualiser::visualise( const IECore::InternedString &attributeName, const IECoreScene::ShaderNetwork *shaderNetwork, const IECoreScene::ShaderNetwork *lightShaderNetwork, const IECore::CompoundObject *attributes, IECoreGL::ConstStatePtr &state ) const
{
if( !lightShaderNetwork )
{
return {};
}

IECoreGL::GroupPtr result = new IECoreGL::Group();

const StringData *visualiserDrawingModeData = attributes->member<StringData>( "gl:light:drawingMode" );
Expand Down
5 changes: 0 additions & 5 deletions src/GafferScene/IECoreGLPreview/LightFilterVisualiser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,6 @@ Visualisations LightFilterVisualiser::allVisualisations( const IECore::CompoundO
lightShaderNetwork = attributes->member<IECoreScene::ShaderNetwork>( "light" );
}

if( !lightShaderNetwork )
{
continue;
}

// It's possible that we found a light filter defined in world space
// that isn't assigned to a light just yet. If we found a filter in
// light space it must have a valid light shader, though.
Expand Down
Loading