LightToCamera : Support USD spot lights #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Aug 30, 2023
| @@ -134,6 +134,12 @@ const char *lightType( const IECore::CompoundData *shaderParameters, const std:: | |||
| return ""; | |||
| } | |||
|
|
|||
| if( boost::starts_with( metadataTarget, "light:" ) && shaderParameters->member<FloatData>( "shaping:cone:angle" ) ) | |||
There was a problem hiding this comment.
This is definitely a step forward for USD lights authored within Gaffer, where we only expect shaping:cone:angle to have been enabled if it is wanted and has a sensible value. But I've seen at least one other DCC that seemed to always author shaping:cone:angle, using a value of 90 (or was it 180?) as a sentinel value meaning "ignore me". I don't know what the official line on that is as UsdLux is badly under specified, but I think it'd be worth us ignoring values >=90 here regardless, since the perspective projection is broken in those cases. I'm going to merge anyway as we wanted to include this in today's release, but I think it might be worth doing a quick follow up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for USD spot lights to LightToCamera, identifying them based on the presence of a
shaping:cone:angleparameter and adding support forconeAngleTypemetadata.