SceneAlgo : Add findAll() method
#5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did spend a while thinking about the possibility of promoting the existing private `findAttributes()` function from SceneAlgo.cpp instead. But that's a fairly esoteric thing that runs a predicate functor on the full attributes, and for `findAllWithAttribute()` my goal was to provide something simpler which could be used from Python without the overhead of a Python functor.
johnhaddon
force-pushed
the
sceneAlgoFind
branch
from
a73c844
to
aca8ca1
Compare
|
Pushed one more commit to add a |
ericmehl
requested changes
Sep 8, 2023
There was a problem hiding this comment.
Very nice! I can see this being useful for a variety of things.
Code here looks good to me.
I get the Windows build working locally if I change
gaffer/src/GafferScene/DeleteObject.cpp
Line 48 in 59cab96
to
GAFFER_NODE_DEFINE_TYPE( GafferScene::DeleteObject );
SceneAlgo.inl added an include of tbb/enumerable_thread_specific.h in this PR. On Windows, that includes the Windows api, which I believe is a C api. So, no namespaces for us. DeleteObject is a function in wingdi.h (the Windows graphics API, gah!) so we need to be specific here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a parallel traversal of the scene, returning a PathMatcher containing all paths for which a predicate returns
true.