Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DispatchDialogue : Use Close instead of Ok #5458

Conversation

chrisc-lee
Copy link
Contributor

Users sometimes click the Ok button, thinking it will take them back to be able to run the dispatch again. Using Close instead of Ok here removes the ambiguity.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

Users sometimes click the Ok button, thinking it will take them back to
be able to run the dispatch again. Using Close instead of Ok here
removes the ambiguity.
@johnhaddon johnhaddon merged commit aa1dd69 into GafferHQ:1.2_maintenance Sep 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants