StandardNodeGadget : Remove raster-space sizing for focus border #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were scaling the size up to make the focus icon more prominent when the graph editor was zoomed out. But this had the unwanted side effect of obscuring more parts of the underlying UI when zoomed out. So while managing focus was easier, some other operations - such as making a connection - became _impossible_ at some zoom levels. This appears to have been further exacerbated by a bug whereby the default scaling was not consistent between 2K and 4K displays, as reported in GafferHQ#5435, making some operations impossible at common zoom levels. Removing this dynamic sizing does make focus management a little harder, but the fixed sizing maintains the relative importance of UI elements across all zoom levels. Let's see how folks get on with it. Fixes GafferHQ#5435.
johnhaddon
requested review from
ivanimanishi,
danieldresser-ie and
murraystevenson
ivanimanishi
approved these changes
Sep 20, 2023
|
Sure, that's simple if it keeps people happy. |
murraystevenson
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were scaling the size up to make the focus icon more prominent when the graph editor was zoomed out. But this had the unwanted side effect of obscuring more parts of the underlying UI when zoomed out. So while managing focus was easier, some other operations - such as making a connection - became impossible at some zoom levels. This appears to have been further exacerbated by a bug whereby the default scaling was not consistent between 2K and 4K displays, as reported in #5435, making some operations impossible at common zoom levels.
Removing this dynamic sizing does make focus management a little harder, but the fixed sizing maintains the relative importance of UI elements across all zoom levels. Let's see how folks get on with it.
Fixes #5435.