Remove deprecations #5469
Merged
Remove deprecations #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our hash caching is now so aggressive that even if the precomputed hash was ignored, we'd still be pulling the hash out of the cache. So we now clear the cache to be sure that if the precomputed hash was ignored, that would trigger another call to `ComputeNode::hash()`.
…lue()` And adjust `TypedPlugTest.testPrecomputedHash()` to actually test a TypedPlug instead of a StringPlug.
johnhaddon
force-pushed
the
removeDeprecations
branch
from
49565af
to
bc31bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just removes a few deprecated methods from the future 1.4 release. They're all pretty esoteric, so I don't expect them to cause anyone any problems.