Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui app : Fix copy and paste on Windows #5511

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

ericmehl
Copy link
Collaborator

It seems that Windows or Qt on Windows emits an extra update signal when copying to the clipboard, thwarting our attempt at not receiving the Qt clipboard update event when syncing the Gaffer clipboard. By checking to make sure there is a real change to make, we don't clobber the Gaffer clipboard's stored IECore::Object with a string.

Fixes #5485

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

It seems that Windows or Qt on Windows emits an extra update signal
when copying to the clipboard, thwarting our attempt at not receiving
the Qt clipboard update event when syncing the Gaffer clipboard. By
checking to make sure there is a real change to make, we don't clobber
the Gaffer clipboard's stored `IECore::Object` with a string.

Fixes GafferHQ#5485
@johnhaddon johnhaddon merged commit ae8a1e9 into GafferHQ:1.3_maintenance Oct 23, 2023
@ericmehl ericmehl deleted the copyPasteWindows branch October 27, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants