Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightPositionTool : Add tool for placing shadows #5558

Merged
merged 7 commits into from
Jan 5, 2024
Merged

LightPositionTool : Add tool for placing shadows #5558

merged 7 commits into from
Jan 5, 2024
+1,795 −12

Commits on Jan 4, 2024

  1. LightPositionTool : Add tool for placing shadows

    @ericmehl
    ericmehl committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    18b1224 View commit details
    Browse the repository at this point in the history

  2. LightSelectionTool : Drag to set pivotDistance

    @ericmehl
    ericmehl committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a50ee28 View commit details
    Browse the repository at this point in the history

  3. TransformTool : Add target transform viewer tip

    @ericmehl
    ericmehl committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f22a800 View commit details
    Browse the repository at this point in the history

  4. LightPositionTool : Add Z-axis rotate handle

    @ericmehl
    ericmehl committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fe8cfac View commit details
    Browse the repository at this point in the history

  5. LightPositionTool : Drag to place targets

    @ericmehl
    ericmehl committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fd90101 View commit details
    Browse the repository at this point in the history

  6. LightPositionTool : Persist handle across scene transforms 

    Previously we were using the final scene transform in world space to
store and calculate the pivot and target points. This meant when
switching from a node upstream of a `Group` node with a transformation,
we would lose the handle because the world space position would not
align with the handle.

Resetting in that case is not necessary if we instead store the
world space transformation from the scene that will receive the edits,
what the `TransformTool` calls the transform space.

Also, by using the upstream path as the key into the pivot and target
maps, we can persist the handle across hierarchy changes if the
transform allows.
    @ericmehl
    ericmehl committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    79dba5f View commit details
    Browse the repository at this point in the history

  7. LightPositionTool : Avoid shadow naming 

    I had originally envisioned more unique methods and variables for
shadow, specular, diffuse light placement modes, but now that I've
gotten into the details of the shadow mode, I don't see why they
couldn't all share pivot and target data. Changing this now will make
future modes easier to add.
    @ericmehl
    ericmehl committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2b4f2bf View commit details
    Browse the repository at this point in the history