Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep Slice #5588

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Deep Slice #5588

merged 5 commits into from
Dec 18, 2023

Commits on Dec 18, 2023

  1. Image Node : Removed unnecessary string copy 

    I could not detect any reason for this copy - I can't see anything that would invalidate the string held by the context during the lifetime of this variable.
    @danieldresser-ie
    danieldresser-ie committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    3b3e7c0 View commit details
    Browse the repository at this point in the history

  2. DeepSampler : Add missing DECLAREPTR

    @danieldresser-ie
    danieldresser-ie committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    f635b57 View commit details
    Browse the repository at this point in the history

  3. GafferImageTest : Add deep test image data. These images are ... 

    These images are intended to make it easy to exercise all cases in deep processing code.

Color values are uniform random, alpha values are a mixture of uniform random values, but also: values clustered very near 1, values of 1, and values of 0 ( these are the values most likely to trigger special cases in deep processing )

Depth values range from 0 to 4.  The difference in the 4 images are how depth values are generated. "Points" means Z and ZBack are set the same, whereas "Volumes" means that ZBack is allowed to range higher than Z. "Float" means that the depths are uniformly distributed, whereas "Int" means depths are limited to integers ( making it more likely that doing a deep merge will produce exact collisions ).

I've put the script used to generate these images in contrib - we could save 170K of test file size by generating these on the fly, but we try to avoid having a dependency on OSL in other tests, and having constant test images makes sense.
    @danieldresser-ie
    danieldresser-ie committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c5ca70a View commit details
    Browse the repository at this point in the history

  4. assertImagesEqual : Add maxDifferenceGreater and maxDifferenceLess 

    This allows using a different tolerance for pixels where A > B and pixels where A < B.
    @danieldresser-ie
    danieldresser-ie committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    db97dd3 View commit details
    Browse the repository at this point in the history

  5. Add DeepSlice, for trimming deep images to particular depths

    @danieldresser-ie
    danieldresser-ie committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9cc5193 View commit details
    Browse the repository at this point in the history