-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shuffle improvements #5590
Shuffle improvements #5590
Commits on Dec 15, 2023
-
ShufflePlugValueWidget : Use widget metadata for
source
and `destin……ation` And align all widgets to the top, so that everything still lines up if the custom widgets use additional vertical space.
Configuration menu - View commit details
-
Copy full SHA for 318ae7f - Browse repository at this point
Copy the full SHA 318ae7fView commit details
Commits on Dec 18, 2023
-
ShufflesPlug : Improve shuffling API
- Add `ignoreMissingSource` argument to `shuffle()`, defaulting to `true` (the original behaviour). - Add `shuffleWithDefaultSource()` method, specifying a fallback source value to be used when a source is missing. These both forward to the same internal function, whose signature I didn't consider suitable for the public API, because of the four permutations of `ignoreMissingSource` and `defaultSource`-null-ness only three make sense.
Configuration menu - View commit details
-
Copy full SHA for bdd69cb - Browse repository at this point
Copy the full SHA bdd69cbView commit details -
Shuffle : Reimplement using ShufflesPlug
This brings it into line with ShuffleAttributes and ShufflePrimitiveVariables, adding a fair bit of functionality over what we had before.
Configuration menu - View commit details
-
Copy full SHA for 9b1f7da - Browse repository at this point
Copy the full SHA 9b1f7daView commit details -
This stuff all worked thanks to `startup/GafferImage/shuffleCompatibility.py`, but we don't want to be relying on that forever. Also add a test that we can load a Shuffle node and its settings from a file saved from Gaffer 1.3.9.0.
Configuration menu - View commit details
-
Copy full SHA for c554fa1 - Browse repository at this point
Copy the full SHA c554fa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a2b46 - Browse repository at this point
Copy the full SHA 77a2b46View commit details -
ChannelPlugValueWidget : Add context menu and "Custom" option
This makes the Widget more useful in technical workflows where you might want string substitutions, expressions or wildcards.
Configuration menu - View commit details
-
Copy full SHA for 4977f34 - Browse repository at this point
Copy the full SHA 4977f34View commit details -
[Un]Premultiply, ImageScatter : Use ChannelPlugValueWidget
I can't see a reason not to use it, now it's a bit more versatile.
Configuration menu - View commit details
-
Copy full SHA for 7a8b5d5 - Browse repository at this point
Copy the full SHA 7a8b5d5View commit details