Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File browser improvements #5593

Merged

Conversation

johnhaddon
Copy link
Member

Small file browser improvements for ArnoldShader, USDLight and OpenColorIOContext, in response to #5592.

Copy link
Collaborator

@ericmehl ericmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for one small comment / question inline, all looks good.

gaffer.path.valid BOOL true
gaffer.path.leaf BOOL true
gaffer.path.bookmarks STRING "texture"
gaffer.fileSystemPath.extensions STRING "tx"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how common it is to use Arnold's automatic .tx conversion - would it be worth registering the aiImage extensions to GafferImage.ImageReader.supportedExtensions() so more image formats are available without having to click off the filter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did wonder about doing that, and wasn't sure what to do. We've gone out of our way to default auto-tx-generation off, because it's not compatible with render-farm usage. And I think maybe gently encouraging people away from using non-mip-mapped formats is a pretty reasonable thing to do. So I may be wrong, but on balance I think it's reasonable to only show the ideal format by default, and have people toggle a checkbox to get at the others...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds reasonable to me, clear to merge from me.

@johnhaddon johnhaddon force-pushed the arnoldBrowserBookmarks branch from d966ad9 to 5aba490 Compare December 19, 2023 16:08
@johnhaddon johnhaddon merged commit 494ee80 into GafferHQ:1.3_maintenance Dec 19, 2023
4 checks passed
@johnhaddon johnhaddon deleted the arnoldBrowserBookmarks branch March 15, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants