-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File browser improvements #5593
File browser improvements #5593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for one small comment / question inline, all looks good.
gaffer.path.valid BOOL true | ||
gaffer.path.leaf BOOL true | ||
gaffer.path.bookmarks STRING "texture" | ||
gaffer.fileSystemPath.extensions STRING "tx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how common it is to use Arnold's automatic .tx conversion - would it be worth registering the aiImage
extensions to GafferImage.ImageReader.supportedExtensions()
so more image formats are available without having to click off the filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did wonder about doing that, and wasn't sure what to do. We've gone out of our way to default auto-tx-generation off, because it's not compatible with render-farm usage. And I think maybe gently encouraging people away from using non-mip-mapped formats is a pretty reasonable thing to do. So I may be wrong, but on balance I think it's reasonable to only show the ideal format by default, and have people toggle a checkbox to get at the others...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable to me, clear to merge from me.
d966ad9
to
5aba490
Compare
Small file browser improvements for ArnoldShader, USDLight and OpenColorIOContext, in response to #5592.