Set MSVC_VERSION #5597
Merged
Set MSVC_VERSION #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SCons will use the latest installed MSVC version by default. We are currently using MSVC 2019 (or for this purpose, toolset 14.2, see https://devblogs.microsoft.com/oldnewthing/20221219-00/?p=107601 for a valiant attempt at explaining MSVC version numbering) so building with a newer compiler installed will fail with "unexpected compiler version" errors. This mismatch will go away when we update to MSVC 2022, but will almost certainly come up again, so it's worth codifying the version we use.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explicitly sets the
MSVC_VERSIONwe're building with. After installing MSVC 2022 to start updating our builds to the VFX Reference platform expectation I found current builds were failing because SCons defaults to the latest compiler it finds. That was attempting to mix compiler versions between newly compiled files and cached builds which it was not happy about.Hopefully this is benign on Linux and will also formalize which compiler version we're targeting via code rather than only in documentation.
Checklist