GraphEditor Connection Cutting #5689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A-mazing! |
johnhaddon
reviewed
Feb 26, 2024
| @@ -726,7 +726,7 @@ void StandardNodeGadget::renderLayer( Layer layer, const Style *style, RenderRea | |||
|
|
|||
| break; | |||
| } | |||
| case GraphLayer::Overlay : | |||
| case GraphLayer::Highlighting : | |||
There was a problem hiding this comment.
This isn't actually sufficient to stop some strikethroughs going on top of the focus gadget - because they are in the same layer, it comes down to which is drawn last. But that's the same as when they were both in the Highlighting layer, so I think that's fine...
murraystevenson
force-pushed
the
dragEditGadget
branch
from
fd52dd6
to
808ed53
Compare
|
Thanks for the input! Pushed a rebase to get |
This gives overlays the opportunity to draw on top of the FocusGadget.
With the FocusGadget moved to render in the Highlighting layer, this change prevents another node's strikethrough from drawing on top of the FocusGadget.
johnhaddon
force-pushed
the
dragEditGadget
branch
from
808ed53
to
889c3ea
Compare
|
Nice one, thanks Murray! I've squashed in all your fixups and merged... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a spare-time couch experiment now tidied up into a PR. Hold
Xand drag to disconnect connections that intersect with the dragged line, orXand click to disconnect those under the cursor. This functionality should cover the alternate approach proposed in #788.Implemented as a separate gadget to keep the logic out of GraphGadget. For lack of a better idea, I've named this the overly generic "DragEditGadget" as this could potentially be extended to do other things, such as create connections between nodules.
First foray into Gadget land, so suggestions are very welcome...