SConstruct : Export node definitions using ExtensionAlgo #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And convert Anaglyph node to demonstrate this in action. There is a slight annoyance here in that the extensions depend on the whole of `buildCore`, because we need to be able to run Gaffer to export them. Which means they get re-exported when anything changes. This is pretty fast anyway, but it can be avoided around by using `scons buildCore` rather than `scons build` when you know extensions don't need to be exported again.
johnhaddon
force-pushed
the
extensionAlgoBuild
branch
from
89d0583
to
341cdff
Compare
- We can't let `NamedTemporaryFile` delete the file for us, because the file needs to be closed for us to be able to open it in `gaffer env python` on Windows, and calling `close()` also deletes. We can do better in Python 3.12 by passing `close_on_delete = False` and then letting the context manager delete the file on exit. - We need to output file paths into the `exportScript` as raw strings, so that Windows `\` characters don't get interpreted as escape characters. - We need to specify the full path to `gaffer.cmd` in `check_call()`.
|
Pushed a commit which hopefully fixes the Windows build errors. |
murraystevenson
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to implement core Gaffer nodes using a Box-authoring workflow, before exporting them as first-class (Python) node definitions using ExtensionAlgo at build time. ExtensionAlgo is still a little rough around the edges, but I think there's a lot of potential in using it for core nodes - I have a reasonably well featured ContactSheet node to follow using this mechanism.