ViewportGadget : Range check gadget ids received from IECoreGL::Selector
#5707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor` I'm hoping this might shed some light on a crash reported on particular laptop hardware. The stack trace indicates that the crash occurs in `gadgetsAtInternal()`, and an out-of-range index seems like a likely candidate.
|
User reports that this does avoid the crash, but that selection is broken, which makes sense if we're getting the wrong ID values back from OpenGL. Worth merging I think, but obviously we now need to figure out why we're getting junk back from OpenGL. Might actually be a driver bug? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping this might shed some light on a crash reported on particular laptop hardware. The stack trace indicates that the crash occurs in
gadgetsAtInternal(), and an out-of-range index seems like a likely candidate.