Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CyclesOptions : Remove samplingPattern #5726

Merged
merged 1 commit into from
Mar 12, 2024

Commits on Mar 12, 2024

  1. CyclesOptions : Remove samplingPattern

    This is a debug-level field in Blender, so it's more appropriate to hide it while allowing a power user to specify it via CustomOptions. Moreover, the presets values we had were out of date and completely non-functional.
    
    I've also verified that [Cycles' standalone default](https://github.com/blender/cycles/blob/v4.0.2/src/scene/integrator.cpp#L127) of `SAMPLING_PATTERN_TABULATED_SOBOL` matches [Blenders's UI default](), so when Gaffer doesn't specify anything, we are getting the intended sampling pattern.
    johnhaddon committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5300bfe View commit details
    Browse the repository at this point in the history