Windows wrapper : Remove "Error(s) running Gaffer" shutdown message #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was ambiguous at best, and misleading at worst when the error originated in the renderer. We also don't have an equivalent in the Linux wrapper, so this brings both platforms closer to parity.
johnhaddon
reviewed
Mar 12, 2024
There was a problem hiding this comment.
LGTM, unless @ericmehl you had specific reason for wanting this on Windows?
|
I think that should be fine, but I agree on putting it in LGTM |
johnhaddon
reviewed
Mar 13, 2024
| @@ -161,7 +161,6 @@ if "%GAFFER_DEBUG%" NEQ "" ( | |||
| ) | |||
|
|
|||
| if %ERRORLEVEL% NEQ 0 ( | |||
There was a problem hiding this comment.
Do we still need this if %ERRORLEVEL% stuff now, or does it all boil down to an unconditional exit /B %ERRORLEVEL%?
There was a problem hiding this comment.
Ah yes, that shouldn't be needed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was ambiguous at best, and misleading at worst when the error originated in the renderer. We also don't have an equivalent in the Linux wrapper, so this brings both platforms closer to parity.
Conservatively targeting this to main as while I wouldn't consider it a breaking change, it is a change in behaviour.