Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shuffle compatibility improvements #5739

Closed
wants to merge 2 commits into from
Closed

Shuffle compatibility improvements #5739

wants to merge 2 commits into from

Commits on Mar 19, 2024

  1. PythonExpressionEngine : Support compatibility configs for renamed plugs 

    The key change here is that `__plug()` now uses a series of `__getitem__` calls rather than a single call to `descendant()`, giving the compatibility configs the ability to monkey-patch a name change in at any step.

The other changes aren't strictly necessary, but I switched from storing plug paths as "dot.separated.strings" to `( "tuples", "of", "names" )` since that's the form we now need them in most commonly, and avoids a bunch of string manipulations for the more common operations. This leaves us doing string manipulations only for the less common error-handling code paths.
    @johnhaddon
    johnhaddon committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    9710107 View commit details
    Browse the repository at this point in the history

  2. Shuffle : Improve ChannelPlug compatibility 

    And add test demonstrating that expressions can still be made using the old names for plugs. This is necessary for an internal expression created by a node at Cinesite.
    @johnhaddon
    johnhaddon committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b8038fc View commit details
    Browse the repository at this point in the history