ScriptNode : Support multi-line if in tolerantExec()
#5747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmehl
approved these changes
Mar 22, 2024
Although we don't make use of any compound statements in our own serialisations, third parties have done so using custom serialisers. Parsing for those was broken by 9d15bd2 when we stopped using an AST for parsing. Here we do the absolute bare minimum necessary to get these legacy files loading. As noted in the comments, we do not intend to do more : rather our future intention is likely to be constrain the serialisation format further for improved performance.
johnhaddon
force-pushed
the
blockSerialisation
branch
from
1c61a3c
to
bb66f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we don't make use of any compound statements in our own serialisations, third parties have done so using custom serialisers. Parsing for those was broken by 9d15bd2 when we stopped using a legacy AST API for parsing. Here we do the absolute bare minimum necessary to get these legacy files loading. As noted in the comments, we do not intend to do more : rather our future intention is likely to be constrain the serialisation format further for improved performance.