Fix selection on Intel GPUs #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling GL_BLEND for selection renders on Intel graphics hardware leads to corrupted ids in the selection buffer, so we now ensure it is disabled for selection renders in `renderInternal`. We also consolidate the enabling of GL_BLEND so it only occurs in `renderInternal`, rather than in various parts of StandardStyle and in `ViewportGadget::render`. This fixes GafferHQ#901 and GafferHQ#2788 on the Intel graphics hardware we have available to test with.
This should no longer be necessary now that we ensure `GL_BLEND` is disabled for selection renders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After positive user feedback that we were on the right track with the GL_BLEND investigation in #5734, this is an adjusted PR with a tidied up fix consolidating the enabling of GL_BLEND so it only occurs in
ViewportGadget::renderInternal, rather than in various parts of StandardStyle andViewportGadget::render.This fixes #901 and #2788 on the Intel graphics hardware we have available to test with, and we'll close those in favour of newer reports of any further issues.