Remove %ERRORLEVEL% conditional exit
#5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, we were echoing an error message when we exited with non-zero exit code. That was removed for clarity, and now this can be simplified even more to remove the check for a non-zero exit code and just forward to exit code as-is to the calling process.
|
Thanks Eric! I did briefly wonder about that when removing the error message, nice to see we can simplify things further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we were echoing an error message when we exited with non-zero exit code. That was removed for clarity in 81012c8, and now this can be simplified even more to remove the check for a non-zero exit code and just forward to exit code as-is to the calling process.
Checklist