Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light tool disable click #5828

Merged
merged 2 commits into from
May 16, 2024
Merged

Light tool disable click #5828

merged 2 commits into from
May 16, 2024

Commits on May 16, 2024

  1. LightPositionTool : Ignore click, drag if hidden 

    Previsouly we were making the light position tool disabled and invisible
if anything except a light is selected. This still allowed clicking
and dragging, so users could still move a non-light object, which is not
our intention.
    @ericmehl @johnhaddon
    ericmehl authored and johnhaddon committed May 16, 2024
    Configuration menu
    Copy the full SHA
    159a66b View commit details
    Browse the repository at this point in the history

  2. LightPositionTool : Default pointer on handles 

    When we moved to showing the `notEditable` pointer for key combinations
that are not clickable / draggable, the `notEditable` pointer would
persist on the rotate and distance handles even when they are editable.

This sets the pointer to the default when the cursor is over those
handles, leaving it to the handle color to indicate editability as is
done elsewhere.

Also switched the check for pivot editability to use `DistanceHandle::getRequiresPivot()` rather than explicit mode checks.
    @ericmehl @johnhaddon
    ericmehl authored and johnhaddon committed May 16, 2024
    Configuration menu
    Copy the full SHA
    fe9d82f View commit details
    Browse the repository at this point in the history