3Delight multipart render support #5844
Conversation
This removes all usage of `boost::variant`, except for one in SetAlgo, where the interaction with `boost::reference_wrapper` makes removal trickier.
Prefer `std::optional` to `boost::optional`
Prefer `std::variant` to `boost::variant`
fix typo
Update CropWindowToolUI.py
Drop support for OpenEXR/Imath 2
|
@johnhaddon Are you OK with switching this PR from |
Yep, that would be great. I haven't tested what would have happened if we pointed two different outputs to the same file before, but I assume it wouldn't have worked. If you could also include a mention in Changes.md that would be great. |
| i = IECoreImage.ImageReader( os.path.join( self.temporaryDirectory(), "multipart.exr" ) ) | ||
| h = i.readHeader() | ||
| subimages = h['oiio:subimages'] | ||
| del i |
There was a problem hiding this comment.
It's not essential that you change this now, but we're close to phasing out IECoreImage.ImageReader everywhere, so if you have time it'd be great if this check could be performed with the OpenImageIO module directly instead.
There was a problem hiding this comment.
Got it! Absolutely no problem to switch the test to the OpenImageIO module.
| @@ -281,7 +281,7 @@ class DelightOutput : public IECore::RefCounted | |||
| driverParams.add( { "drivername", &typePtr, NSITypeString, 0, 1, 0 } ); | |||
| driverParams.add( { "imagefilename", &namePtr, NSITypeString, 0, 1, 0 } ); | |||
|
|
|||
| m_driverHandle = DelightHandle( context, "outputDriver:" + name, ownership, "outputdriver", driverParams ); | |||
| m_driverHandle = DelightHandle( context, "outputDriver:" + output->getName(), ownership, "outputdriver", driverParams ); | |||
There was a problem hiding this comment.
Amazing how simple this is! Might be worth a comment stating that NSICreate will just return an existing node if the handle already exists and that's how we coalesce multi-part. I only learned about that detail very recently.
There was a problem hiding this comment.
Sounds good! Will update the code with the comment.
Great! Thanks! Previously the same file name wouldn't have worked because the two Gaffer outputs would create two different NSI outputdriver nodes. Absolutely no problem to update the Changes.md file. |
|
I think switching the base branch from |
Generally describe what this PR will do, and why it is needed
Checklist