Render adaptor fixes #5872
Merged
Render adaptor fixes #5872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were pulling on the adapted globals, which themselves could depend on `resolvedRenderer` via the `renderer` input to the adaptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of important fixes to the render adaptor mechanism, including for a crash that is hindering usage at Cinesite. I've made the PR for
1.4_maintenancesince that it where the problem is most pronounced. But we could also backport to1.3_maintenancewith the removal of theInteractiveRenderTest.testAdaptorGlobalsDependingOnRenderer.