ShaderTweakProxyUI : Fix when nodule menu appears #5873
Conversation
| # but that seems like a pretty weird case, and we want to get to the early out without doing too much traversal | ||
| destPlug = Gaffer.PlugAlgo.findDestination( plug, lambda plug : plug if not plug.outputs() else None ) |
There was a problem hiding this comment.
I don't think "too much traversal" is really a worry here is it? We use findDestination() in far more performance-critical places, like PlugValueWidget construction. The more canonical thing seems to be to use the Shader/ShaderTweaks check as the predicate, and then we don't need this NOTE at all.
|
Ugh, I've found another problem : the "Create proxy" button is showing up for popup editors in the LightEditor and the SceneViewInspector. We'll need to get it hidden for those...maybe the easiest fix is to only create it when the plug is directly parented to a ShaderTweaks node? |
johnhaddon
force-pushed
the
shaderTweakProxyFix
branch
from
6125ae7 to
98c51a7
Compare
|
In the interests of getting a release out today, I've pushed two more commits directly to this branch. The first is a fixup addressing my original review comment, and the second fixes the unwanted "Create proxy" button and another bug I found in the process of doing that. |
|
LGTM. Sorry for the noise. Should I squash the fixup so someone can hit merge? |
- Remove unused `__updateReadOnly()` method - Disable button when plug is read-only. - Hide button unless plug is directly on a ShaderTweaks node.
johnhaddon
force-pushed
the
shaderTweakProxyFix
branch
from
98c51a7 to
bbd1add
Compare
All good - I've just done it. |
Correcting the error John caught on #5842 after merging.