Loop improvements #5912
Merged
Loop improvements #5912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now disables the Loop, instead of creating a context variable with an empty name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides some groundwork for the upcoming context tracking utility I'm working on. This will generalise the "active branch highlighting" feature from the GraphEditor into something that also provides sensible evaluation contexts for active nodes. In the GraphEditor, we currently punt when we hit a Loop and just evaluate nodes in the loop body with a fallback context. I don't think that's going to cut it for the more general feature, so my intention is to evaluate the loop body once in the context corresponding to the first iteration of the loop. This PR adds a
nextIterationContext()method to facilitate that, and also fixes a corner case in the index variable handling.