ColorChooser : Don't emit signals with inconsistent internal state #5917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want all our ducks in a row before being exposed to the arbitrary code execution represented by connected slots. I haven't observed any problems from the old code in practice, but noticed the pre-exising bug while reviewing GafferHQ#5909 and thought it probably worth addressing while we're looking at this part of the codebase.
ericmehl
reviewed
Jun 24, 2024
|
Thanks for the clarification @johnhaddon, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want all our ducks in a row before being exposed to the arbitrary code execution represented by connected slots. I haven't observed any problems from the old code in practice, but noticed the pre-exising bug while reviewing #5909 and thought it probably worth addressing while we're looking at this part of the codebase.