Popup window colorspace fix #5925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murraystevenson
approved these changes
Jun 28, 2024
This allows the PopupWindow to inherit the display transform from the main UI, and allows `ancestor()` to be used to find things like the main ScriptWindow. I used `Menu.popup()` as the model for this since it is the closest related API we have. One potential downside is that the parenting isn't performed in Qt, meaning among other things that it won't be visited by `Widget.__propagateDisplayTransformChange`. I think this is probably good enough for now though, as popup windows are ephemeral and the display transform shouldn't change while they are open.
johnhaddon
force-pushed
the
popupWindowColorspace
branch
from
65725f2
to
c06bc0d
Compare
|
Rebased and retargeted to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug whereby the ephemeral
PlugPopupwindows we use to display temporary editors were not inheriting the correct display transform from the main UI.